Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use sast fingerprint when comparing source and target scan results #748

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Use sast fingerprint when comparing source and target scan results #748

merged 3 commits into from
Sep 11, 2024

Conversation

orz25
Copy link
Contributor

@orz25 orz25 commented Sep 9, 2024 •
edited by attiasas
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • Update documentation about new features / new supported technologies

Depends on:

@orz25 orz25 added the safe to test Approve running integration tests on a pull request label Sep 9, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 9, 2024
@orz25 orz25 added improvement Automatically generated release notes safe to test Approve running integration tests on a pull request labels Sep 9, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 9, 2024
@orz25 orz25 requested review from eranturgeman and attiasas and removed request for eranturgeman September 9, 2024 12:58
attiasas
attiasas reviewed Sep 9, 2024
View reviewed changes
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! is it possible to add a test case for this? similar issues with diff fingerprints?

@orz25 orz25 added the safe to test Approve running integration tests on a pull request label Sep 11, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 11, 2024
@orz25 orz25 added the safe to test Approve running integration tests on a pull request label Sep 11, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.

@orz25 orz25 merged commit 788f66a into jfrog:dev Sep 11, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attiasas attiasas attiasas left review comments

@eranturgeman eranturgeman Awaiting requested review from eranturgeman

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orz25 @attiasas